search

msys2-contrib / cpython-mingw

A friendly fork of CPython which adds support for Mingw-w64 + clang/gcc. See https://github.com/msys2-contrib/cpython-mingw/wiki for details
https://github.com/msys2-contrib/cpython-mingw/wiki
Other
38 stars 12 forks source link

PyO3: adjust mingw support to use the limited ABI again #173

Closed lazka closed 4 months ago

lazka commented 4 months ago

Just a tracking issue.

We initially added upstream support in https://github.com/PyO3/pyo3/pull/1423 but since then we gained support for the limited ABI in https://github.com/msys2-contrib/cpython-mingw/pull/148

We should try to adjust the upstream code to use the limited ABI again, so there is less difference compared to official CPython, maybe the PR can be completely reverted even.

lazka commented 4 months ago

Turns out this is already fixed upstream (maybe by accident?)

The abi3 feature in pyo3 is now opt-in, and mingw isn't treated separately anymore.

In maturin one can select abi3 support and I can confirm that the resulting Python extension uses the right DLL.