msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.28k stars 1.22k forks source link

package mingw-w64-x86_64-srecord will not compile using 'C' #20799

Closed vero-board closed 6 months ago

vero-board commented 6 months ago

Description / Steps to reproduce the issue

problem using 'C'. The srecord include folder contains problem one; "string.h" has the same name as used in by libc. problem two; The file includes which is a C++ file.

There is nothing to say that this is a C++ only package!, therefore I would expect it to build in 'C'

Expected behavior

string.h needs to be called something else. reference to C++ code needs to be changes to be 'C'.

Actual behavior

C:\msys64\mingw64\include\srecord/string.h:22:10: fatal error: string: No such file or directory 22 | #include

Verification

Windows Version

MSYS_NT-10.0-19045

MINGW environments affected

Are you willing to submit a PR?

no

MehdiChinoune commented 6 months ago

Please report the issue to the upstream (https://github.com/sierrafoxtrot/srecord/issues), not an MSYS2 issue. And BTW srecord is a C++ project (written in C++) don't expect its headers to be compatible with C.