[nodejs] Windows version check fails

[TerrorJack]

Description / Steps to reproduce the issue

$ which node
/clang64/bin/node
$ node --version
Node.js is only supported on Windows 8.1, Windows Server 2012 R2, or higher.
Setting the NODE_SKIP_PLATFORM_CHECK environment variable to 1 skips this
check, but Node.js might not execute correctly. Any issues encountered on
unsupported platforms will not be fixed.

The above occurs on a Windows 11 23H2 (22631.3880) x86_64 machine.

Expected behavior

node should work out of the box.

Actual behavior

node fails version check.

Verification

• [X] I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

MINGW64_NT-10.0-22631

MINGW environments affected

• [ ] MINGW64
• [ ] MINGW32
• [ ] UCRT64
• [X] CLANG64
• [ ] CLANG32
• [ ] CLANGARM64

Are you willing to submit a PR?

No response

[lazka]

confirmed.

@raedrizqie looks like we dropped https://github.com/msys2/MINGW-packages/pull/17411 maybe?

I wonder why our integration tests don't catch this: https://github.com/msys2/msys2-tests/blob/main/nodejs/test.sh - I wonder if GHA sets NODE_SKIP_PLATFORM_CHECK or something

edit: heh, I asked myself that before: https://github.com/msys2/MINGW-packages/pull/17411#issuecomment-1574213892

[Biswa96]

It feels like one of those missing manifest file issues where gcc links those implicitly. Can the issue be reproduced in ucrt64/mingw64?

[raedrizqie]

@TerrorJack which version are you using? the current nodejs already have embedded manifest file in the exe..

[ognevny]

I got that issue in latest Windows 11 (not from windows insider)

[raedrizqie]

this error should also affect upstream binaries.. but i cannot find any similar issue reported

[lazka]

I can confirm that the manifest is missing

[raedrizqie]

ok, i will look into it soonish