search

msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.31k stars 1.23k forks source link

gimp3: Build GIMP non relocatable #22481

Open brunvonlope opened 2 weeks ago

brunvonlope commented 2 weeks ago

This drops a superfluous .patch and build GIMP as non-relocatable, which is the expected way to run it in MSYS2 shells.

ping @hmartinez82

lazka commented 2 weeks ago

This disables lots of relocation code in gimp (see ENABLE_RELOCATABLE_RESOURCES). Are you sure this is what we want?

brunvonlope commented 2 weeks ago

Are you sure this is what we want?

@lazka No, not sure. I'm new to MSYS2 GUI packages so that depends on what the MSYS2 project usually expects from its packages. They should be relocatable or non-relocatable?

If we suppose that the clang64 folder can be copied or moved freely, so relocatable-bundle=yes. If no so the project assumes that the clang64 works like a system prefix in the UNIX way, so relocatable-bundle=no.

mmuetzel commented 2 weeks ago

All packages distributed by MSYS2 must be relocatable in the sense that a user can choose any prefix for their MSYS2 installation. For one user, that might result in /c/msys64/ucrt64 as the prefix for their UCRT64 environment. For another user, that might be /d/my_msys2/ucrt64. For a third user, it might be something completely different.

Do you know what "relocatable" means for GIMP? Does it still support different prefixes even if it is built non-relocatable?

brunvonlope commented 2 weeks ago

@mmuetzel Thanks. For GIMP, "relocatable" means exactly what you described. We will probably drop this bundling code being run by default or rework to be less pervasive, as @Jehan already pointed it to me on IRC.