msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.3k stars 1.23k forks source link

zed: `zed-download-pc-windows-gnu-assets.patch` breaks tools donwload #22511

Closed mati865 closed 1 week ago

mati865 commented 1 week ago

Description / Steps to reproduce the issue

Neither rust-analyzer nor deno provide windows-gnu artifacts, so the patch is conceptually wrong.

Expected behavior

No errors.

Actual behavior

An error when opening a Rust project:

Language server error: rust-analyzer

no asset found matching `"rust-analyzer-x86_64-pc-windows-gnu.gz"`
-- stderr--

Verification

Windows Version

MINGW64_NT-10.0-22631

MINGW environments affected

Are you willing to submit a PR?

No response

ognevny commented 1 week ago

oops, I wanted to remove this patch actually, thanks for catch

ognevny commented 1 week ago

you can download rust-analyzer from msys2. it should be available from $PATH to work on Zed

mati865 commented 1 week ago

I know, just noticed the patch is wrong.

ognevny commented 1 week ago

also in zed 0.162.x rust-analyzer will be downloaded in a bit another way: https://github.com/zed-industries/zed/commit/181c3724aa99e67ebc5f8147dce8d6ee2f77276d