search

msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.31k stars 1.23k forks source link

jsoncpp: correct name of static library #22585

Closed mmuetzel closed 1 week ago

mmuetzel commented 1 week ago

Fixes #22584.

sharkwouter commented 1 week ago

It seems this change was made in this PR to enable Clang to work: https://github.com/open-source-parsers/jsoncpp/pull/1480

Maybe upstream has an idea on how to make this condition only activate for MSVC and Clang instead of every WIN32 build.

mmuetzel commented 1 week ago

A better condition for upstream would probably be MSVC OR ("${CMAKE_C_SIMULATE_ID}" STREQUAL "MSVC"). But MSYS2 always targets MinGW (not MSVC). So, the second part of that condition would never be true when packaging for MSYS2.

mmuetzel commented 1 week ago

Thank you for testing and for digging up that PR.

I created a PR for upstream with a change that should work with any compiler when targeting MSVC: https://github.com/open-source-parsers/jsoncpp/pull/1579