msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.3k stars 1.23k forks source link

Add libp11 #22589

Open mlt opened 6 days ago

lazka commented 4 days ago

OK with my changes?

(we can always improve things later if needed)

mlt commented 3 days ago

Good catches! I should probably clean up the readme as well (at least the last paragraph). I was hesitating if it belongs there, but I think it might be helpful on how to configure things.

I took quite a detour trying to figuring out how to make things work on Windows with PATHs & escaping in configs, MSVC vs gcc, token/object names with vendor module vs emulated, etc. It took some time with Procmon. Then I realized that everything normally is going through p11-kit on all platforms and should be on Windows as well to unify configuration and minimize that for end apps. I even have opensc package for msys2 but I believe it is deadborn for 2 reasons: 1) the official installer and pkcs11 module work fine as is (no need to bring extra DLLs on PATH like with ykcs11), 2) we can't build minidriver anyway as it requires Cryptographic Provider Development Kit. So unless you encourage to submit a PR, I'd bury it.

lazka commented 2 days ago

I don't really know anything about these projects, so I can't really say.