msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.25k stars 1.21k forks source link

Latest crt and headers break multiple packages. #4601

Closed revelator closed 5 years ago

revelator commented 5 years ago

Some recent updates in the mingw-w64 repo has done away with the need for some mingw specific hacks used in multiple sources, unfortunatly as long as they are not updated to reflect that we can no longer build them. git for instance no longer builds with errors about pollfd (now part of winsock2.h).

I started patching the affected packages, so i guess i will no longer be able to avoid having to fork this repo to do commits :P

Alexpux commented 5 years ago

@revelator I think this is because I switch mingw-w64 runtime minimum version to Win7

revelator commented 5 years ago

Makes sense seing as it now defaults to _WIN32_WINNT=0x0600 which enables those extensions.

revelator commented 5 years ago

workaround for the time being is to set CPPFLAGS+=" -D_WIN32_WINNT=0x0501" on the packages that croak.

mati865 commented 5 years ago

If you are seeing these errors on Windows 7 or newer then you should report it on mingw-w64 mailing list.

lazka commented 5 years ago

@revelator is there anything left to fix/improve here?

lazka commented 5 years ago

I guess not. Feel free to open another issue or post here.