search

msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.27k stars 1.21k forks source link

scalapack patching script #6660

Closed revelator closed 8 months ago

revelator commented 4 years ago

Was -> prepare() { cd "${srcdir}/${_realname}-${pkgver}" for p in ${srcdir}/../*.patch; do patch -p1 < $p done }

which would resolve to patch -p1 -i ${srcdir}/../somepatch.patch

should probably be ->

prepare() { cd "${srcdir}/${_realname}-${pkgver}" for p in ${srcdir}/*.patch; do patch -p1 < $p done }

so that it follows the normal way patching is done eg. patch -p1 -i ${srcdir}/somepatch.patch

Biswa96 commented 4 years ago

There is a cd "${srcdir}/${_realname}-${pkgver}" before patch command and the patch command does not have the -i option. So, do the rest ;)

revelator commented 4 years ago

well there is in the pull from master i did so oversight maybe ?.

revelator commented 4 years ago

Ah np no there is no -i in the script but it still resolves to -p1 ${srcdir}/../somepatch.patch and srcdir is static it is allways the root of the PKGBUILD so if i build it in D: it will look for the patch in D:/mingw-w64-scalapack and not in D:/mingw-w64-scalapack/src. the reason i think it might work for you is that you build it without BUILDDIR set so the patches are present in the lower level dir. Eg. you have the mingw-packages repo on C:/mingw-packages so you also have C:/mingw-packages/mingw-w64-scalapack/somepatch.patch but if you build in D: you have D:/mingw-w64-scalapack/ but no patches in it since pacman only copies those to the srcdir so they are located in D:/mingw-w64-scalapack/src.

MehdiChinoune commented 8 months ago

PKGBUILD was updated