search

msys2 / MSYS2-packages

Package scripts for MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
1.3k stars 490 forks source link

filesystem: cannot start msys2 shell on wine #616

Open andreygursky opened 8 years ago

andreygursky commented 8 years ago

The patch a7b0cf62a6bda0ee34b8bf07b08c798b6afb1c0e states that working directory handling has been improved. Unfortunately it doesn't specify in what way. Moreover it is not clear, whether the patch addresses only one issue and not more.

Specifically the following line causes breakage on wine: https://github.com/Alexpux/MSYS2-packages/commit/a7b0cf62a6#diff-2f01ca07ce0c63426e67943cbebdd212R28.

After that it got even worse. The patch 7b3055f9d7dc770997d28dabce42437b0a38bf8f states the movement of duplicated code. In fact it does more than that. It introduces a new loop "checkparams" https://github.com/Alexpux/MSYS2-packages/commit/7b3055f9d7dc770997d28dabce42437b0a38bf8f#diff-9608ff5131fbf03f7ff0a44464d6e085R15 which turns to be a forever loop on wine.

andreygursky commented 8 years ago

These issues has been reported on wine:

But you know it can take years (if not decades) to fix them, thus I hope a much easier workaround in MSYS2 could be applied.

ghost commented 8 years ago

@andreygursky don't blame Msys2 developers, as a Wine contributor I suggest to blame Wine... :)

An easy workaround is MSYSTEM=MSYS wine usr/bin/mintty.exe --exec /usr/bin/bash -l

If some one have time to work on those Wine bug that would be great... I'll try if I can find any volunteers.

ghost commented 8 years ago

@andreygursky BTW, we spent more than one year to support MSYS2 on Wine: https://goo.gl/GaUiYl

We are always welcome new contributors to work on MSYS2 + Wine :) There is a Full Stack on Wine plan in WineConf2015: https://wiki.winehq.org/WineConf2015#Agenda Volunteers are more than welcome!

andreygursky commented 8 years ago

@andreygursky don't blame Msys2 developers, as a Wine contributor I suggest to blame Wine... :)

I'm not that blaming :), but rather I like to know, whether these improvement are such valuable and cannot be done another way and why one thing is mentioned in a commit message and then more things are done, which is not a good rule generally.

I'll try if I can find any volunteers.

Not that I will be a volunteer. But every time I'm reading a bug report (from a developer or advanced user) I'm always grateful if a way to solve an issue is at least sketched. You never know someone find the information complete enough to take a look at it (without needing to ask and wait, which could be often a show stopper).

andreygursky commented 8 years ago

BTW, we spent more than one year to support MSYS2 on Wine

Thanks for links. I'm really curious, how it turned that wine supports many closed source programs, but it took such an effort to support open source ones. Thanks for this!

Wine USB Overview, Current status, Next steps

Oh, interesting. But discussion - no slides, no records?

ghost commented 8 years ago

I'm really curious, how it turned that wine supports many closed source programs, but it took such an effort to support open source ones.

Some closed source programs are really even more difficult. For Wine Msys2, the difficult things have been done, what we need now is running a "racing game" to make sure Wine updates fast enough to catch Msys2 updates ;)

Oh, interesting. But discussion - no slides, no records?

No slides and records for "discussion".