Rebuild if a dependency is no longer in the queue

msys2 / msys2-autobuild

🏭🏭🏭🏭🏭🏭🏭🏭

https://packages.msys2.org/queue

MIT License

35 stars 25 forks source link

Rebuild if a dependency is no longer in the queue #54

Open lazka opened 2 years ago

lazka commented 2 years ago

Scenario as happened in https://github.com/msys2/MINGW-packages/pull/11156

package + rebuilds get added to the queue
package gets reverted
rebuild stays and gets added to the repo
boom

Potential fixes:

Store the list of dependencies used from the queue alongside the build
If one of those packages is no longer there, throw out the current build
Downside: requires extra fetches for every package...

lazka commented 2 years ago

An simpler way might be to delete/ignore all packages uploaded after the removed build. That will lead to more rebuilds, but means we don't have to track dependencies.

Delete all newer than packages that need to be cleaned during the scheduler (no builds should be active, otherwise this is racy)
Ignore all packages that are to be deleted in fetch-assets, to they don't end up in stating/the repo.

lazka commented 1 year ago

Another problem is a dependency cycle that is finished and the wrong package gets updated/deleted, resulting in the wrong build order, since one of them is already in staging.

lazka commented 1 year ago

Another option is to fail and require for some manual input to continue (either delete deps, or continue as now)