search

msys2 / msys2-installer

The one-click installer for MSYS2
BSD 3-Clause "New" or "Revised" License
590 stars 88 forks source link

make installation path argument default #20

Closed beliaev-maksim closed 3 years ago

beliaev-maksim commented 3 years ago

Hi guys,

right now in the header you write that installation path is optional but it will not work without argument

I make a check if argument is empty and set some default dir C:/MSYS64 or may be you have a better hook to grab default system directory the same way we do in graphical mode? if yes, then we can set it to dynamic value

also I think InstallDir is better argument name and it consistent with variable name you had

Fabien-Chouteau commented 3 years ago

FYI,changing the name of the command line argument broke our automatic installation in the Alire package manager.