search

msys2 / msys2-pacman

A friendly fork of https://gitlab.archlinux.org/pacman/pacman
GNU General Public License v2.0
21 stars 12 forks source link

Patch cleanup ideas #29

Open lazka opened 1 year ago

lazka commented 1 year ago

1) as pointed out in https://github.com/msys2/MSYS2-packages/pull/3594#issuecomment-1451360330 it's questionable how we call gpg there

2) https://github.com/msys2/msys2-pacman/commit/1fbb46db545fad72daab79d769f19a4ae4cea6e3 can likely be dropped

3) https://github.com/msys2/msys2-pacman/commit/c8025392f733b5b28687a8b468191354cd037415 should be moved where other things are exported and I don't think "DXSDK_DIR ACLOCAL_PATH PKG_CONFIG_PATH" is actually needed

4) https://github.com/msys2/msys2-pacman/commit/6b51761d44cca57f66d8adfa18fa03496474b514#diff-ebd20edda3f2f2f4112739efa148c55502c0bc59f9b357c882ee23b2db46983d set -e is missing

5) I'm wondering if all this is actually needed and calling "file" is enough: https://github.com/msys2/msys2-pacman/commit/3077636f7466dfce19894666ae3a3284a8889279#diff-b39914dda73d12220ebef7e970cd3f7613f04113293e673f7936695a8969bc2aR118-R185 also file is called again in strip for no reason

6) This seems questionable: https://github.com/msys2/msys2-pacman/commit/235ea43e9a0d3d4a373a37970a62be8dfd32282b

and more...

lazka commented 1 year ago

Aha, I found the likely source of the stripping logic: https://repo.or.cz/cygport/rpm-style.git/blob/HEAD:/lib/src_postinst.cygpart#l933