search

msys2 / msys2-pacman

A friendly fork of https://gitlab.archlinux.org/pacman/pacman
GNU General Public License v2.0
21 stars 12 forks source link

libmakepkg: .com needs to be handled as an extension for win32 executable #35

Open nu774 opened 5 months ago

nu774 commented 5 months ago

https://github.com/msys2/msys2-pacman/commit/3077636f7466dfce19894666ae3a3284a8889279 doesn't take care of the .com extension. It's at least used by mpv (mpv uses both of mpv.exe and mpv.com).

lazka commented 5 months ago

Thanks, that's something we should consider when tackling https://github.com/msys2/msys2-pacman/issues/29

nu774 commented 5 months ago

BTW, you should also note that this line:

if LANG=en_US.UTF-8 LC_ALL=C objdump -f "${binary}" | grep -Eq '^start address 0x(0000000[01])?00401[0-9a-e][0-9a-e]0'

catches only x86 exe but not x64 exe. cf. https://learn.microsoft.com/en-us/cpp/build/reference/base-base-address?view=msvc-170