search

msys2 / msys2-pacman

A friendly fork of https://gitlab.archlinux.org/pacman/pacman
GNU General Public License v2.0
21 stars 12 forks source link

Strip static libraries as well #8

Closed MehdiChinoune closed 2 years ago

MehdiChinoune commented 2 years ago

Fixes #7

mati865 commented 2 years ago

I assume you have tested this because binutils used to break static libs when stripping them in the past.

MehdiChinoune commented 2 years ago

I assume you have tested this because binutils used to break static libs when stripping them in the past.

No, I didn't. I thought the maintainers forgot to strip them (as they got stripped on Arch). Did binutils used to break them on every platform or on MinGW-w64? if the first then many Linux distributions strip them without problem

mati865 commented 2 years ago

I have rarely seen this issue on Linux but I wasn't using static libs a lot. On Windows though it was quite common to the point I stopped stripping static libraries there. No idea about current state because I don't develop for Windows any more.

MehdiChinoune commented 2 years ago

The staticlibs were stripped before upgrading to pacman 6.0 see: https://github.com/msys2/msys2-pacman/blob/msys2-v5.2.2/scripts/libmakepkg/tidy/strip.sh.in#L187

lazka commented 2 years ago

thanks, I probably missed it during the rebase