msys2 / msys2-runtime

Our friendly fork of Cygwin 💖 https://cygwin.org 💖 see the wiki for details
https://github.com/msys2/msys2-runtime/wiki
GNU General Public License v2.0
185 stars 39 forks source link

Prevent different MSYS2 runtime versions from sharing cygheaps #192

Closed dscho closed 4 months ago

dscho commented 9 months ago

This allows users to run Cygwin programs from an MSYS2 Bash even when the MSYS2 runtime version corresponds to the Cygwin runtime version used by those Cygwin programs.

Incidentally, it also allows calling Git for Windows' Bash from the MSYS2 Bash.

dscho commented 9 months ago

@lazka @Biswa96 @jeremyd2019 any thoughts whether to merge this now, or hold off until after switching to MSYS2 runtime v3.5.0?

dscho commented 9 months ago

@Biswa96 was that a 👍 for merging now, or a 👍 for holding off until v3.5.0?

lazka commented 9 months ago

I'd prefer to wait a bit

Biswa96 commented 9 months ago

I can not see any potential issue with this change. So, :+1: for merging it.

lazka commented 4 months ago

I'm fine with merging this, still ok?