Open dscho opened 7 months ago
Just integrated the build artifacts 😞
:x:python3 -c "import sys; print(sys.argv)" --dir=/this:./there
['-c', '--dir=/this:./there']
['-c', '--dir=C:\\msys64\\this;.\\there']
:x:python3 -c "import sys; print(sys.argv)" --dir=./this:./there
['-c', '--dir=./this:./there']
['-c', '--dir=.\\this;.\\there']
:x:python3 -c "import sys; print(sys.argv)" --WEBINPUTS=.:../../../texk/web2c
['-c', '--WEBINPUTS=.:../../../texk/web2c']
['-c', '--WEBINPUTS=.;..\\..\\..\\texk\\web2c']
When we fixed MSYS2's automatic Unix <-> Windows path conversion to identify and skip Git-style
<rev>:<path>
arguments (and incidentally also scp-style<host>:<path>
ones), we assumed that path lists containing relative paths would be a rare scenario.My, was this assumption wrong!
Let's add another heuristic that detects absolute paths at the beginning of path lists, and relative ones starting with either
./
or../
, neither of which match those Git-style nor scp-style arguments, and then prevent the detection of the latter style from kicking in.This addresses https://github.com/msys2/msys2-runtime/issues/208