msys2 / setup-msys2

GitHub Action to setup MSYS2
https://github.com/marketplace/actions/setup-msys2
MIT License
297 stars 40 forks source link

sometimes action is very slow #346

Closed ognevny closed 9 months ago

ognevny commented 9 months ago

I have set up action that uses msys2 for building Cargo project. most recent workflows went very long because setup-msys2 took ~3 minutes (compared to ~1.5 mins that was before).

maybe it's GitHub issue, but I want to let you know

Biswa96 commented 9 months ago

Could you compare the time in CI log to find exactly which step(s) took more time?

ognevny commented 9 months ago

Could you compare the time in CI log to find exactly which step(s) took more time?

the same workflow

slow: https://github.com/ognevnydemon/ognlib/actions/runs/7301001096/job/19896742737 normal: https://github.com/ognevnydemon/ognlib/actions/runs/7301001096/job/19896743164

jeremyd2019 commented 9 months ago

I've noticed that sometimes apparently at the end of the action it just hangs out for a couple of extra minutes. I first noticed this after the switch to node20.

ognevny commented 9 months ago

in this action it ran 4.5 minutes!

dimitre commented 9 months ago

[edit] ignore this comment, @Biswa96 already clarified how to do that ~~I also noticed this: https://github.com/openframeworks/openFrameworks/actions/workflows/build-msys2.yml it would be great if we had an elapsed time for each step of the action to see which parts take more time. Thank you~~

Biswa96 commented 9 months ago

it would be great if we had an elapsed time for each step of the action to see which parts take more time.

The raw CI log has timestamps prepended with every line.

jeremyd2019 commented 9 months ago

In my case it seemed to be taking time after the last line in the step's log, before starting the next step.

lazka commented 9 months ago

Comparing various slow and fast jobs, the difference seems to be that only jobs which upload the cache hang at the end.

lazka commented 9 months ago

Downgrading to node16 seems to fix it :(

lazka commented 9 months ago

Upstream issue https://github.com/actions/toolkit/issues/1578

lazka commented 9 months ago

new release is out