search

mszep / pandoc_resume

The Markdown Resume
http://mszep.github.io/pandoc_resume/
MIT License
1.65k stars 758 forks source link

feat(docker): provide docker integration #19

Closed TheDonDope closed 7 years ago

TheDonDope commented 7 years ago

Provide docker integration to being able to run within a container.

mszep commented 7 years ago

Whoa, this is awesome, thank you!

Out of curiosity though (and not knowing much about docker), what's the use case for running inside docker? Is it just to not have to install packages to the base system?

TheDonDope commented 7 years ago

Hey @mszep!

You are correct. My use-case was that i have multiple computers with different operating systems.
A apt-get install pandoc contex may work easy enough on debian derivates, but what about windows for example?

So, with this PR, all you need is to have Docker installed on your machine, and no further prerequisites :) I will update the PR with some minor changes, before i'd suggest it to be merged.

There is one pitfall however. My docker base image is ubuntu, which is a little heavyweight, especially the apt-get update and installing the dependencies takes a few minutes. However this is still a boatload faster than trying to install pandoc/context on windows :)

TheDonDope commented 7 years ago

Alright, i'm done!

mszep commented 7 years ago

Many thanks, will merge!

Incidentally, if you have any other suggestions for updates or enhancements, let me know!