search

mszep / pandoc_resume

The Markdown Resume
http://mszep.github.io/pandoc_resume/
MIT License
1.65k stars 758 forks source link

replaced deprecated -S with -smart #36

Closed treymerkley closed 6 years ago

treymerkley commented 6 years ago

-S breaks some of the conversion. Fixed with changing to -smart.

mszep commented 6 years ago

Thanks for pointing this out!

What does the -smart option do again? Is it exclusive to docx and rtf output? If so, we'll need to figure out a workaround due to the new architecture of the Makefile.

treymerkley commented 6 years ago

I don't know much about it. I just know that the script failed with that as the error, but fixing it made everything come out right. It complained that a couple of other options were headed that way, and I'll look into updating those too before they break entirely.

nitrocode commented 6 years ago

So the version in Ubuntu Xenial is 1.16.0.2 and the latest Pandoc is 2.1.2 and the difference is the older version uses --smart whereas the new version uses -smart. In PR #37, I detected the pandoc version and applied the correct switch.

treymerkley commented 6 years ago

Great! I'm using an Arch variant, which explains the discrepancy.

mszep commented 6 years ago

Merged #37