mszostok / codeowners-validator

The GitHub CODEOWNERS file validator
Apache License 2.0
212 stars 47 forks source link

Remove required owner for syntax checker (#94) #101

Closed athtran closed 2 years ago

athtran commented 2 years ago

Description

Changes proposed in this pull request:

This PR removes the missing owner syntax check, as this is a valid use case to explicitly specify that a path has no owner.

Related issue(s)

Resolves #94

mszostok commented 2 years ago

Hi, thanks for your PR. I agree that the missing owner is a valid case and syntax checker shouldn't report it.

Nevertheless, I wanted to keep it, so I just moved this check under owner checker and made it optional. In this way, validator may work in a picky when needed. (fixed by https://github.com/mszostok/codeowners-validator/pull/113)

For more info, please see my comment here: https://github.com/mszostok/codeowners-validator/issues/94#issuecomment-1037515981 🙂