search

mszostok / codeowners-validator

The GitHub CODEOWNERS file validator
Apache License 2.0
212 stars 48 forks source link

Support Github App authentication #146

Closed julienduchesne closed 2 years ago

julienduchesne commented 2 years ago

Using a Github App has the benefit that API calls count towards that app installation instead of a user This is useful in cases where you want to limit the number of automation users but have no such limits on Apps, since they are free

Let me know what you think!

julienduchesne commented 2 years ago

Thanks for the great review @mszostok!

mszostok commented 2 years ago

I pushed a dedicated commit https://github.com/mszostok/codeowners-validator/pull/146/commits/1915c98e1686517414ea94d3f0cb5eeac1336763 with e2e test changes. Changes that you applied LGTM, CI is green, so I'm merging the PR.

Once again, thanks for your contribution! The new release will be done once I will merge the https://github.com/mszostok/codeowners-validator/pull/149 and https://github.com/mszostok/codeowners-validator/pull/148