Update install.sh - Githubissues

mszostok / codeowners-validator

The GitHub CODEOWNERS file validator

Apache License 2.0

211 stars 48 forks source link

Update install.sh #184

Open frankpengau opened 1 year ago

frankpengau commented 1 year ago

Description

Changes proposed in this pull request:

adding linux/arm64 to get codeowners-validator binary

Related issue(s)

Resolves #183

frankpengau commented 1 year ago

Just realised that the install.sh was auto-generated and should not be edited. Will change this PR.

frankpengau commented 1 year ago

Was looking into the auto-generation of install.sh by godownloader, but then upon digging into godownloader it seems like it is archived.

frankpengau commented 1 year ago

In the file: .goreleaser.yml , there seems to be an ignore for windows arm64:

    ignore:
      - goos: windows # due to upx error: CantPackException: can't pack new-exe
        goarch: arm64

Does it need an archives replacements for arm64 in the following:

archives:
  - replacements:
      darwin: Darwin
      linux: Linux
      windows: Windows
      386: i386
      amd64: x86_64
    format_overrides:
      - goos: windows
        format: zip

Not sure if it was intentional, due to the upx issue mentioned in: #174

frankpengau commented 1 year ago

Correction: After testing locally, it seems to be an actual problem with the auto-generated install.sh missing the linux/arm64 platform.

mszostok commented 1 year ago

Hi @frankpengau!

Thanks for reporting this issue and this pull-request. I will handle that this weekend.

When it comes to the install.sh script, I think that I should figure out sth different, as this is deprecated. I used this tool, https://github.com/goreleaser/godownloader, but it's not maintained anymore.

Probably I will leave only the brew and directly binaries downloads from GitHub releases.