Support outside collaborators in owners check

mszostok / codeowners-validator

The GitHub CODEOWNERS file validator

Apache License 2.0

211 stars 48 forks source link

Open bobertrublik opened 1 year ago

bobertrublik commented 1 year ago

Description

Changes proposed in this pull request:

add an outsideCollaborators map
add initOutsideCollaboratorsList() function to fill outsideCollaborators map
additionally check in validateGitHubUser() whether a given username is an outside collaborator

Related issue(s)

bobertrublik commented 1 year ago

I applied your suggestions! :) Sorry for taking so long, I've been sick for the last two weeks.

PS: I guess it would have a made more sense to apply the changes in new commits instead of modifying the original commit.

bobertrublik commented 1 year ago

Thank you for approving. :) Is the error in the integration test caused by my changes?

infinisil commented 2 months ago

I just opened https://github.com/mszostok/codeowners-validator/pull/222 which I believe would be a better fix for this :)