mszostok / codeowners-validator

The GitHub CODEOWNERS file validator
Apache License 2.0
221 stars 47 forks source link

Omitting an owner should not fail codeowners-validator #206

Closed erikkerber closed 9 months ago

erikkerber commented 10 months ago

Description

If there is a config option I'm misinterpreting forgive me.

If I have a pattern without a team owner:

My/Owned/file.txt

The validator will fail:

line 84: Missing owner, at least one owner is required

This is a valid line and should not fail by default. This behavior is called out in GitHub's docs:

# In this example, @octocat owns any file in the `/apps`
# directory in the root of your repository except for the `/apps/github`
# subdirectory, as its owners are left empty.
/apps/ @octocat
/apps/github

Expected result

Does not fail by default in this scenario

Actual result

line 84: Missing owner, at least one owner is required
erikkerber commented 9 months ago

Turns out this was fixed in 0.7.0. Thanks and sorry for the noise 🙇🏼