mszostok / codeowners-validator

The GitHub CODEOWNERS file validator
Apache License 2.0
211 stars 48 forks source link

Check for user write access (also, more speed and less code!) #222

Open infinisil opened 2 months ago

infinisil commented 2 months ago

Description

This PR improves the owners check:

See the commits for more details.

Other than the locally runnable tests, I've also tested this minimally with an actual GitHub org repo

Related issue(s)


This work is sponsored by Antithesis :sparkles:

infinisil commented 2 months ago

Just discovered that when using this with a GitHub App, it needs the "Repository/Administration/read-only" permission instead of the "Organization/Members/read-only" permission, see https://github.com/NixOS/org/pull/9. So I guess this is a breaking change. I only updated the documentation for now, but I imagine more might be needed because of this.

Edit: Needs to be updated to clarify Repository/Administration instead of Organization/Administration