Closed knl closed 3 years ago
ICYMI: Please see my comment https://github.com/mszostok/codeowners-validator/pull/34#pullrequestreview-404882383 :)
btw. documentation for the token in owners
check was added https://github.com/mszostok/codeowners-validator/pull/36
Description
If CODEOWNERS file contains a comment towards the end of the line, the validator doesn't flag it as invalid. In case of such comments, GitHub will skip the rest of the file.
Example:
Expected result
I would expect the above snippet to be marked as problematic.
Actual result
Note that I'm not using
owners
check, as it is not clear what kind of right are needed for the token (but that is a separate issue).Steps to reproduce
Write a comment after a correct line (so that
#
is not the first character in the line).Troubleshooting