search

mszostok / codeowners-validator

The GitHub CODEOWNERS file validator
Apache License 2.0
217 stars 47 forks source link

Fix file exists checker #44

Closed mszostok closed 3 years ago

mszostok commented 3 years ago

Description

The main problem was that the file exists checker was using Go's built-in filepath.Glob method which doesn't support double-asterisk patterns.

Additionally, with patterns like *.js we need to search for all JS files, not only on the first level but also in nested directories.

Based on made investigation this problem was fixed and additional test coverage was added to document that contract.

Related issue(s)

Fixes https://github.com/mszostok/codeowners-validator/issues/42 Fixes https://github.com/mszostok/codeowners-validator/issues/22

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 into master will increase coverage by 6.49%. The diff coverage is 67.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   18.26%   24.76%   +6.49%     
==========================================
  Files          10       10              
  Lines         312      323      +11     
==========================================
+ Hits           57       80      +23     
+ Misses        252      239      -13     
- Partials        3        4       +1
Impacted Files Coverage Δ
internal/check/not_owned_file.go 0.00% <0.00%> (ø)
internal/check/valid_owner.go 0.00% <0.00%> (ø)
internal/check/api.go 36.66% <75.00%> (+19.42%) :arrow_up:
internal/check/file_exists.go 77.27% <93.33%> (+77.27%) :arrow_up:
internal/check/duplicated_pattern.go 78.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbda10c...1de2a20. Read the comment docs.