mszostok / codeowners-validator

The GitHub CODEOWNERS file validator
Apache License 2.0
217 stars 47 forks source link

Add test coverage report from integration tests #49

Open mszostok opened 3 years ago

mszostok commented 3 years ago

Description

The test coverage is pushed to the codecov.io platform: https://codecov.io/gh/mszostok/codeowners-validator

But the coverage raport is generated only from the unit-test. The problem is that not every checker is easy to test with unit test. For example, the owners_check executes external calls and mocking that does not make sens. Instead the integration testing is ensuring that the contract is fulfilled.

As a part of that task we should add the coverage report for the integration tests. There is already an option to do that:

Acceptance Criteria: [ ] Add coverage report for integration tests [ ] Push to the codecov.io coverage report which contains both the unit-test and integration-test coverage [ ] Add test coverage badge to README.md

Reasons

We should be able to detect which part of the validator is not covered by our tests and be able to write a missing tests.