Closed miguelslemos closed 3 years ago
Merging #53 into master will increase coverage by
2.00%
. The diff coverage is53.84%
.
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 43.81% 45.82% +2.00%
==========================================
Files 12 13 +1
Lines 372 371 -1
==========================================
+ Hits 163 170 +7
+ Misses 207 199 -8
Partials 2 2
Impacted Files | Coverage Ξ | |
---|---|---|
internal/check/valid_owner.go | 10.78% <0.00%> (+0.87%) |
:arrow_up: |
internal/check/valid_owner_check.go | 87.50% <87.50%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 0b6c2ef...8316766. Read the comment docs.
Hi, I decided to merge that PR as it is 100% valid. I extracted the generalization logic to a saparate issue π The user facing behaviour will stay the same, so by default the @ghost user will be deleted :)
Once again, thanks for your contribution and increasing test coverage π
FYI: Integration tests are not executed on forked PR but I've checked it locally and all green π
Description Add ignore case for user
@ghost
https://github.community/t5/How-to-use-Git-and-GitHub/CODEOWNERS-file-with-a-NOT-file-type-condition/m-p/31013/highlight/true#M8523Related issue(s)
Fixes #52