mszostok / codeowners-validator

The GitHub CODEOWNERS file validator
Apache License 2.0
217 stars 47 forks source link

Add configurability for the list of ignored owners #55

Closed majakurcius closed 3 years ago

majakurcius commented 3 years ago

Description

Changes proposed in this pull request:

Related issue(s)

Fixes #54

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 into master will increase coverage by 4.31%. The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   45.82%   50.13%   +4.31%     
==========================================
  Files          13       12       -1     
  Lines         371      375       +4     
==========================================
+ Hits          170      188      +18     
+ Misses        199      183      -16     
- Partials        2        4       +2     
Impacted Files Coverage Ξ”
internal/check/valid_owner.go 29.82% <82.35%> (+19.04%) :arrow_up:
internal/check/valid_owner_error.go 50.00% <0.00%> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 97fb795...c3e71ce. Read the comment docs.

mszostok commented 3 years ago

As discussed f2f, the integration tests are not working on forked PRs (yet πŸ™ ). This will be documented in a separate PR :)

merging πŸš€