msztolcman / sendria

Sendria (formerly MailTrap) is a SMTP server designed to run in your dev/test environment, that is designed to catch any email you or your application is sending, and display it in a web interface instead of sending to real world.
MIT License
149 stars 14 forks source link

Dockerfile improvements #10

Closed chytreg closed 2 years ago

chytreg commented 2 years ago
msztolcman commented 2 years ago

Hi @chytreg, Thank you for your contribution. I was playing with Dockerfile for sendria some time ago in dockerfile-playgames branch, but I think it's too complicated and don't want to merge it. Your version is very good: simple and readable, works fine for most usages, doesn't contain stuff specific for development (as @Arzaroth requested some time ago). And I think I should follow this way, for dev-specific we can (and will do) create separate Dockerfile.

The only thing I don't want to is --no-quit argument as default. It's easy to add it when you are starting sendria, but there is no easy way to drop it - you must override whole entrypoint to do this. Could you please remove just this one thing? Then I will merge your PR. Thanks!

msztolcman commented 2 years ago

@chytreg Thanks! Merged :)