Use dune foreign archive to fix liburing version

mt-caret / io_uring

ISC License

8 stars 2 forks source link

Use dune foreign archive to fix liburing version #5

Closed mt-caret closed 3 years ago

mt-caret commented 3 years ago

I mashed the keyboard until something compiled, and I have no idea what I'm doing here...

@jawline do you have any idea if this is the right approach I'm taking here?

jawline commented 3 years ago

Oh awesome I didn't realize there was a facility for third party build scripts.

I'm probably not the best to vet this but all of your changes look sensible. One thing that might cause issue is you don't have a git submodule update --init --recursive in the build command so if opam / the downloading user doesn't do a recursive checkout it won't work (I'm actually not sure how that would work with opam artifacts, maybe it's already taken care of).