search

mt-from-sf-to-gh / bugs

0 stars 0 forks source link

Save Button disappeared from Tour Editor #126

Closed mt-from-sf-to-gh closed 2 years ago

mt-from-sf-to-gh commented 3 years ago

Hi Wolfgang, on the most recent version (mytourbook-21.3.0-linux-64.zip) I can't no longer see the save button on the Tour Editor. I used the version 19.7.1 until now and where was a little floppy disk symbol on the header. My usually workflow is the following:

With the save button missing, I will be asked to save the modified tour once I try to close MyTourbook. As an alternative I may add the information via the "Quick Edit" dialogue. But e.g. I can't the pressure information via the Quick Edit.

If I try to select a different tour after having modified the current one, I'm getting a warning message that this was not possible before the modified tour was saved.

So far, I could not find any other possibility to save the tour. Neither via a RightMouseButton menu or via "Ctrl" + "S" or ...

I've attached a couple of screenshots showing the behaviour with the previous and the current version.

Reported by: moppeluk

Original Ticket: mytourbook/bugs/124

mt-from-sf-to-gh commented 3 years ago

The tour save actions were modified in 19.10

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

Sorry, I had missed that change, having not updated for quite a while. I have found the icons now and can confirm them working. One smaller issue. The tooltip on the icon says Ctrl + S is the shortcut for saving. Wenn pressing this shortcut, the screen (map) flickers very shortly but the in front of "Tour Editor" doesn't disappear. Neither may I select a different tour. However, when pressing Ctrl + Z (after having pressed Ctrl + S) and confirm that I really want to revert the tour, I noticed that the modification was* saved ;-). (I've tested this multiple times on multiple tours.)

Original comment by: moppeluk

mt-from-sf-to-gh commented 3 years ago

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

I could not verify your issue

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

Ctrl+S and Ctrl+Z are only working when the tour editor is the active view

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

When selecting another tour and the current tour is modified in the tour editor, then the tour editor shows a red message at the top of the view

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

I added a short screencast video demonstrating the behaviour. The Tour Editor was selected. Ctrl + S worked but partially only. Meaning the changes where saved but the saving wasn't reflected on the UI. Ctrl + Z worked all the time.

java -version
openjdk version "15.0.3" 2021-04-20
OpenJDK Runtime Environment (build 15.0.3+3-suse-1.2-x8664)
OpenJDK 64-Bit Server VM (build 15.0.3+3-suse-1.2-x8664, mixed mode)

Original comment by: moppeluk

mt-from-sf-to-gh commented 3 years ago

Fixed in https://github.com/wolfgang-ch/mytourbook/commit/cd01e69c733f5b1a587dc4ef13b5a4465a65653d

This issue happened only on Linux why I've not seen it on W10

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

Original comment by: wolfgang-ch