mt-from-sf-to-gh / bugs

0 stars 0 forks source link

Tour Reimport altitude only = ascent/descent not reimported #127

Closed mt-from-sf-to-gh closed 2 years ago

mt-from-sf-to-gh commented 3 years ago

Hello, I do each time altitude corrections, and save. After saving, i need to go back to initial fit file data --> i reimport tour from fit.

With current version : either altitude reimport only, or even complete tour reimport, gives me same result : altitude graph (values)is well reimported but total ascent/descent is still the one before reimport (= the one calculated and saved after altitude correction). Only way to get initial values = delete tour and begin from scratch.

here is small screenshots : 1 = initial tour values 2 = values after altitude correction 3 = altitude or whole tour reimport logs

example : create tour = import fit file altitude correction = altitude start=altitude end --> ascent change from 271m to 300m reimport fit file altitude --> altitude values reimported but ascent still 300m reimport all tour --> same effect Need to delete tour and reimport from scratch.

1 = initial tour values

2 = values after altitude correction

3 = altitude or whole tour reimport logs

Reported by: mff73

Original Ticket: mytourbook/bugs/125

mt-from-sf-to-gh commented 3 years ago

Diff:


--- old
+++ new
@@ -17,3 +17,8 @@
 reimport all tour --> same effect
 Need to delete tour and reimport from scratch.

+![](https://sourceforge.net/p/mytourbook/bugs/125/attachment/1.jpg)
+
+![](https://sourceforge.net/p/mytourbook/bugs/125/attachment/2.jpg)
+
+![](https://sourceforge.net/p/mytourbook/bugs/125/attachment/3.jpg)

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

Diff:


--- old
+++ new
@@ -17,8 +17,11 @@
 reimport all tour --> same effect
 Need to delete tour and reimport from scratch.

+1 = initial tour values
 ![](https://sourceforge.net/p/mytourbook/bugs/125/attachment/1.jpg)

+2 = values after altitude correction
 ![](https://sourceforge.net/p/mytourbook/bugs/125/attachment/2.jpg)

+3 = altitude or whole tour reimport logs
 ![](https://sourceforge.net/p/mytourbook/bugs/125/attachment/3.jpg)

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

Fixed in https://github.com/wolfgang-ch/mytourbook/commit/5e7d27dce3c6e4575e66a8e1201ae1a213de45e4

Original comment by: wolfgang-ch

mt-from-sf-to-gh commented 3 years ago

I don't understand the code, but i trust your fix, waiting for release to use it, thanks for this.

Original comment by: mff73