mt-mods / abriglass

Stained glass mod for Minetest
Other
1 stars 2 forks source link

LBM Conversion only worked on some nodes, not on others #8

Open Bastrabun opened 1 year ago

Bastrabun commented 1 year ago

abriglass:stained_glass_frosted or abriglass:stained_glass_blue didn't convert, whatever colour is behind param6 did.

There may be more examples I didn't find yet

fluxionary commented 1 year ago

i tested this, and LBM conversion worked on all the variants. it's a run-once LBM, did it perhaps run on your world once, you reverted it and placed some nodes, then tried again?

wsor4035 commented 1 year ago

additionally works for me. to add additional info to flux comment, iirc lbm runs are tracked in env_meta.txt, so you might be able to delete progress out of there for it to start over on map blocks. citation needed

wsor4035 commented 1 year ago

looking at my env_meta.txt file,

lbm_introduction_times = :doors:replace_doors_door_glass~0;:doors:replace_doors_door_obsidian_glass~0;:doors:replace_doors_door_steel~0;:doors:replace_doors_door_wood~0;:doors:replace_xpanes_door_steel_bar~0;:farming:start_nodetimer_cotton~0;:farming:start_nodetimer_wheat~0;default:3dtorch~0;default:convert_saplings_to_node_timer~0;default:upgrade_chest_locked_v2~0;default:upgrade_chest_v2~0;xpanes:gen2~0;abriglass:glass_convert~4830;abriglass:lightglass_convert~4830;
lbm_introduction_times_version = 1

seems i recalled the file correctly. dont recall how to edit it out nicely i would guess deleete abriglass:glass_convert~4830;abriglass:lightglass_convert~4830; off the end - please test on a backup first, etc

wsor4035 commented 1 year ago

talked to Bastrabun, will fix some other stuff tonight

wsor4035 commented 1 year ago

hmm, going to keep this open just in case for the lbm stuff for a little bit longer, till @Bastrabun does more testing anyways, fixed the other stuff

Bastrabun commented 2 months ago

I tested abriglass on the testserver again. The placed blocks were nicely migrated, also chests, autocrafter, various inventories, even those currently underway in a pipworks tube.

What didn't work were itemframes: they display coloured blocks in pure white now. That affects

Both kinds also had to be taken out of itemframes and placed back into them once to at least display the white variant. Note sure if abriglass bug or itemframe bug.

For my reference 5775