mt-mods / beerchat

beerchat mod for minetest
GNU Lesser General Public License v3.0
9 stars 7 forks source link

Rethink and rework required channel alias permissions #102

Closed S-S-X closed 1 year ago

S-S-X commented 1 year ago

Admin privilege should be used to bypass all possible checks, maybe even special channel protection.

Moderator privilege should probably just check if player has access to both channels, currently it checks if player is owner of both channels.

SwissalpS commented 1 year ago

So if player A created #español but isn't active anymore but channel is being used and now they want an alias #castellano only admin could do that?
Since Player B is owner of #castellano?

S-S-X commented 1 year ago

So if player A created #español but isn't active anymore but channel is being used and now they want an alias #castellano only admin could do that? Since Player B is owner of #castellano?

Currently it is like that. And even then only with ban privilege. Source: https://github.com/mt-mods/beerchat/blob/0f106b119e7e5c39b44fbd1f8f22099fcbff6cb5/plugin/alias.lua#L129-L139

So I was thinking making it work like this: