Auto generate list w/ cheat client hashes

mt-mods / beowulf

anticheat mod

MIT License

9 stars 2 forks source link

Auto generate list w/ cheat client hashes #20

Open Niklp09 opened 3 months ago

Niklp09 commented 3 months ago

Todo:

Make sure the gh actions workflow works

From SSX (https://github.com/mt-mods/beowulf/issues/19#issuecomment-2107652946)

For automated updates be sure to not drop any of removed hashes, with df which seems to be most used of these I've seen many hashes that were already dropped by rewrites.

I'm not sure yet how to do that... Any ideas? :smile:

S-S-X commented 3 months ago

I'm not sure yet how to do that... Any ideas?

I guess simplest would be to take existing list and new list then just do merge.

Montandalar commented 3 months ago

This looks like it uses short hashes instead of full hashes. That could create a hash collision with the main Minetest project. Why not use the full length sha256 hashes? It's not like space is a concern.

Niklp09 commented 3 months ago

Yes this could happen, but the version_string of clients only contains the short commit hash. I'm probably wrong but I don't think there's an advantage of the full-length hashes then.

S-S-X commented 3 months ago

Yes it is short only and besides that there wouldn't really be any real benefits because of how extremely unlikely it is to get collision even with short hashes and then also get real cheater who actually would be affected by that collision. I bet it wont happen in next few hundred years without crafted collision (and there's no point in that either as you can just edit version info anyway).