search

mt-mods / dreambuilder_game

Dreambuilder is an attempt to give the player pretty much everything they'll ever want to build with, and all the tools they should ever need to actually get the job done.
Other
5 stars 6 forks source link

Update .gitmodules #576

Closed SwissalpS closed 6 months ago

SwissalpS commented 6 months ago

adopting cheapie's mods as they are no longer interested in maintaining minetest mods

Q: is there something more that needs to be done apart from changing .gitmodules file? I don't often deal with gitmodules and something tells me this wasn't all.

wsor4035 commented 6 months ago

see https://github.com/mt-mods/dreambuilder_game/pull/337

wsor4035 commented 6 months ago

forcing a rerun of the tests, not sure why there are failing/not running, possibly because this was before https://github.com/mt-mods/dreambuilder_game/commit/59406bf4c6f137bc751d864465adf5ebdc9cd694 ?

SwissalpS commented 6 months ago

image

please switch to https://github.com/mt-mods/invsaw/

I'd prefer merging this after #527 is merged, then we can add some others too.

SwissalpS commented 6 months ago

forcing a rerun of the tests, not sure why there are failing/not running, possibly because this was before 59406bf ?

In #527 I pulled in changes from master and tests still fail.

wsor4035 commented 6 months ago

forcing a rerun of the tests, not sure why there are failing/not running, possibly because this was before 59406bf ?

In #527 I pulled in changes from master and tests still fail.

reading the next issue points out the actual issue with the tests: https://github.com/mt-mods/dreambuilder_game/pull/576#pullrequestreview-1938003728

wsor4035 commented 6 months ago

the tests are failing since frankly @BuckarooBanzay broke dreambuilder by deleting the repos before they where removed as submodules from other projects. further more it might have been better to just transfer those repos over to mt-mods, so that github did redirects and not a clean break

BuckarooBanzay commented 6 months ago

the tests are failing since frankly @BuckarooBanzay broke dreambuilder by deleting the repos before they where removed as submodules from other projects. further more it might have been better to just transfer those repos over to mt-mods, so that github did redirects and not a clean break

oh sh... sorry, forgot about that :/