mt-mods / homedecor_modpack

home decor
Other
2 stars 9 forks source link

make homedecor game agnostic #28

Closed wsor4035 closed 2 years ago

wsor4035 commented 2 years ago

may interest @BuckarooBanzay @sfence

wsor4035 commented 2 years ago

note to self, add metatable to homedecor.materials, so that unknown materials return ""

sfence commented 2 years ago

I recommend you to use something like "--unknown--" for materials without definitions in materials.lua file.

Using string "" can easily cause craft recipe conflicts.

wsor4035 commented 2 years ago

I recommend you to use something like "--unknown--" for materials without definitions in materials.lua file.

Using string "" can easily cause craft recipe conflicts.

yeah, ik, was a note to myself that ill probably do when done, to return a string of some sort, havent decided what yet

wsor4035 commented 2 years ago

@sfence would you be willing to help expand the table for hades revisited itemstrings?

sfence commented 2 years ago

@sfence would you be willing to help expand the table for hades revisited itemstrings?

Added clay_brick and obsidian_glass.

elseif minetest.get_modpath("hades_core") then
    homedecor.materials = {
        sand = "hades_core:fertile_sand",
        gravel = "hades_core:gravel",
        copper_ingot = "hades_core:copper_ingot",
        steel_ingot = "hades_core:steel_ingot",
        gold_ingot = "hades_core:gold_ingot",
        tin_ingot = "hades_core:tin_ingot",
        silver_ingot = "--unknown--",
        mese_crystal_fragment = "hades_core:mese_crystal_fragment",
        torch = "hades_torches:torch",
        diamond = "hades_core:diamond",
        clay_lump = "hades_core:clay_lump",
        clay_brick = "hades_core:clay_brick",

        --[[
            Since hades doesnt have buckets or water for the user,
            using dirt from near water to pull the water out
        ]]
        water_bucket = "hades_core:dirt",
        empty_bucket = "hades_core:fertile_sand",
        dye_dark_grey = "dye:dark_grey",
        dye_black = "dye:black",
        dye_white = "dye:white",
        dye_green = "dye:green",
        dye_red = "dye:red",
        dye_yellow = "dye:yellow",
        dye_brown = "dye:brown",
        dye_blue = "dye:blue",
        dye_violet = "dye:violet",
        dye_grey = "dye:grey",
        dye_dark_green = "dye:dark_green",
        dye_orange = "dye:orange",
        dye_pink = "dye:pink",
        silicon = "hades_materials:silicon",
        string = "hades_farming:string",
        paper = "hades_core:paper",
        book = "hades_core:book",
        iron_lump = "hades_core:iron_lump",
        wool_grey = "wool:grey",
        wool_green = "wool:green",
        wool_dark_green = "wool:dark_green",
        wool_brown = "wool:brown",
        wool_black = "wool:black",
        wool_white = "wool:white",
        slab_stone = "stairs:slab_stone",
        slab_wood = "stairs:slab_wood",
        glass_block = "hades_core:glass",
        glass_bottle = "vessels:glass_bottle",
        obsidian_glass = "hades_core:obsidian_glass",
        coal_lump = "hades_core:coal_lump",
        stone = "hades_core:stone",
        cobble = "hades_core:cobble",
        brick = "hades_core:brick"
    }

    if minetest.get_modpath("hades_bucket") then
        homedecor.materials["water_bucket"] = "hades_bucket:bucket_water"
        homedecor.materials["empty_bucket"] = "hades_bucket:bucket_empty"
    end
    if minetest.get_modpath("hades_extraores") then
        homedecor.materials["silver_ingot"] = "hades_extraores:silver_ingot"
    end
end
wsor4035 commented 2 years ago

Thank you for the updated table

fluxionary commented 2 years ago

Just noting that I have serious reservations about breaking the functionality of something as basic as sound, unless a server operator figures out they have to install a new, external mod, without telegraphing the breaking change much more.

But there's enough improvement that I'd rather approve this instead of arguing that at the moment.

S-S-X commented 2 years ago

Just add similar "how to install" instructions that https://github.com/mt-mods/basic_materials has. (maybe also better to include that in todo list)