Invalid colorwallmounted param2 can be generated on homedecor:glowlight_small_cube_14

[debagos]

Stack trace:

ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'wielded_light' in callback environment_Step(): ...minetest-5.5.0/bin/../mods/mesecons/mesecons/presets.lua:67: attempt to index local 'dir' (a nil value)
ERROR[Main]: stack traceback:
ERROR[Main]:    ...minetest-5.5.0/bin/../mods/mesecons/mesecons/presets.lua:67: in function 'get_any_inputrules'
ERROR[Main]:    ...inetest-5.5.0/bin/../mods/mesecons/mesecons/internal.lua:97: in function 'get_any_rules'
ERROR[Main]:    ...etest-5.5.0/bin/../mods/mesecons/mesecons_wires/init.lua:81: in function <...etest-5.5.0/bin/../mods/mesecons/mesecons_wires/init.lua:67>
ERROR[Main]:    ...test-5.5.0/bin/../mods/mesecons/mesecons/actionqueue.lua:137: in function 'execute'
ERROR[Main]:    ...test-5.5.0/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...test-5.5.0/bin/../mods/mesecons/mesecons/actionqueue.lua:73>
ERROR[Main]:    ...i/github/minetest-5.5.0/bin/../builtin/game/register.lua:425: in function <...i/github/minetest-5.5.0/bin/../builtin/game/register.lua:409>

For more details please see https://github.com/minetest-mods/mesecons/issues/610

[wsor4035]

appears to be a issue with mesecons. not here

[TurkeyMcMac]

The issue is due to an invalid param2 value. That could be an issue with this mod, or perhaps with unifieddyes.

[wsor4035]

from https://github.com/minetest-mods/mesecons/issues/610#issuecomment-1118542959

paramtype2 = "colorwallmounted" param2 = 30

param2 of 30 is a valid param2

[TurkeyMcMac]

30 % 8 = 6. With paramtype2 = "colorwallmounted", it must hold that param2 % 8 < 6.

[wsor4035]

https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L734-L744 nowhere does it state param2 % 8 < 6 (unless you would like to point a reference out). at any rate mesecons should have a check for param2 up to 7, as thats the highest it should be able to go

[TurkeyMcMac]

See here: https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L1062

[wsor4035]

See here: https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L1062

ah, so your required to assume that colorwallmounted inherits this from wallmounted. still

at any rate mesecons should have a check for param2 up to 7, as thats the highest it should be able to go

[wsor4035]

@TurkeyMcMac should this issue stay here, or be moved to unifieddyes you think? as to create the node, i believe it would have to come from there

[TurkeyMcMac]

I suppose it should be moved to unifieddyes.

[wsor4035]

done, changed title

[OgelGames]

https://github.com/pandorabox-io/pandorabox.io/issues/514

[OgelGames]

The correct place for this issue is homedecor, it's a bug with the node, not unifieddyes.

[wsor4035]

no, the issue is with unifieddyes as it is what allows the node param2 to be changed via crafting or the airbrush

[wsor4035]

from ogelgames: could be another tool like technics screwdriver. was not able to replicated with the regular one

[wsor4035]

update, was able to replicate with technics sonic screwdriver, not only did it create the invalid param2, it also broke the coloring of the node

[wsor4035]

actual issue is the tool in technic, closing this

[OgelGames]

No, it's not, it's an issue with anything that sets a bad param2. Unless this has been fixed, it should stay open.

[wsor4035]

it's an issue with anything that sets a bad param2

thank you for making my point for me its an issue with the thing that sets the bad param2, the node can do nothing about that, thus NOT a homedecor issue

[wsor4035]

the actual issue has an issue tracking it over on technic: https://github.com/mt-mods/technic/issues/267 this is completely redundant and pointless

[OgelGames]

Okay, mesecons was patched to fix this crash over a year ago: https://github.com/minetest-mods/mesecons/pull/623

So yeah, this issue can be closed 👍