mt-mods / homedecor_modpack

home decor
Other
2 stars 9 forks source link

add cottages recipes only when cottages is available #47

Closed Niklp09 closed 1 year ago

wsor4035 commented 1 year ago

what is the point of this? minetest engine lets you register crafts of items that arent present, and almost all inventory mods just ignore crafting recipes that require items that dont exist.

Niklp09 commented 1 year ago

I thought it would be smart to only register recipes for mods that are actually turned on. See it as "cleanup"

BuckarooBanzay commented 1 year ago

what is the point of this? minetest engine lets you register crafts of items that arent present, and almost all inventory mods just ignore crafting recipes that require items that dont exist.

IMO: why register a recipe if you can't use it, the "cleanup" here is justified if you ask me :shrug:

Niklp09 commented 1 year ago

reopen?

wsor4035 commented 1 year ago

what is the point of this? minetest engine lets you register crafts of items that arent present, and almost all inventory mods just ignore crafting recipes that require items that dont exist.

IMO: why register a recipe if you can't use it, the "cleanup" here is justified if you ask me :shrug:

Why not? Anyways, it's less checking you have to do and allows mods to alias items to those crafts if cottages isn't present to have the crafts work. Otherwise your reimplementing all the crafts in your mod. This is semi common. So in fact this pr code be a breaking change

debagos commented 1 year ago

it's less checking you have to do

Don't you have to do one check anyway to see if you have to register the alias or not?

S-S-X commented 1 year ago

I do think it is often better to check mods for crafting but can see what wsor is telling: registering crafts blindly allows less strict use of those crafts through mods named differently as long as items are provided.

it's less checking you have to do

Don't you have to do one check anyway to see if you have to register the alias or not?

Not responsibility here, aliases are registered elsewhere. edit. if you mean registering crafts with missing items, yeah not cool but also not issue. 100% legal.