mt-mods / homedecor_modpack

home decor
Other
2 stars 9 forks source link

Fix missing coloured kitchen cabinets #73

Closed monk-afk closed 3 months ago

monk-afk commented 3 months ago

Addresses cabinets missing in issues #4 and #41

image

Coloured cabinets are craftable after applying patch, image image

monk-afk commented 3 months ago

Understood and applied.

I would like to add, having the unifieddyes registration within the homedecor_common/register.lua file could be useful to fix the ordering of recipe outputs of those with the ud_param2_colorable group.

wsor4035 commented 3 months ago

not sure why your overriding the method, instead of just calling the crafting function itself

monk-afk commented 3 months ago

It's a temporary override. After the cabinets are registered, it gives back the old_homedecor_register function to homedecor.register, and no other items are registered with the override function.

It is to get the cabinet's item names and call unifieddyes.register_color_craft before the cabinets are registered.

I'm not sure how else to get all the different item names and register the color craft before the node craft, short of adding a call to register_color_craft above each node registration.

wsor4035 commented 3 months ago

there is this loop: https://github.com/mt-mods/homedecor_modpack/blob/master/homedecor_kitchen/init.lua#L164 or homedecor.kitchen_convert_nodes which could be looped over to register the craft

monk-afk commented 3 months ago

homedecor.kitchen_convert_nodes is a table populated with the nodes after they are registered.

Maybe moving the table insertions before the cabinet_materials traversal would work.

I'll giver a shot and see

monk-afk commented 3 months ago

I'm sorry, there is no way to accomplish your request.