search

mt-mods / jumpdrive

Minetest jumpdrive mod
Other
9 stars 10 forks source link

low priority: books can disappear if user really tries hard #37

Closed SwissalpS closed 5 years ago

SwissalpS commented 5 years ago

https://github.com/thomasrudin-mt/jumpdrive/blob/3f537615099f2c8c6555b63cc591958179adc41d/common.lua#L304

If book is emptied by user manually it still registers as a written book and does not give nil when deserialized. Same applies if all lines are commented out.

To reproduce: take a book with coordinates and comment out the line. Place in jumpdrive and press "read from book" 2nd way: manually replace title and contents with a space and save.

This was detected by xercyst. I told him that was user error but mention it here anyway.

thomasrudin commented 5 years ago

I told him that was user error but mention it here anyway.

Oook, thx for reporting, i'll keep that open to fix someday (TM) :smile:

thomasrudin commented 5 years ago

Thanks! :+1:

By the way: i'm consolidating my repos, i may move this one to the pandorabox-io org, just fyi...