mt-mods / mcl_fish_traps

GNU General Public License v3.0
0 stars 1 forks source link

Mod seems to have issues with signs in Mineclonia #1

Open Laudrin opened 10 months ago

Laudrin commented 10 months ago

Thank you for the mod! :-)

I read about the incompatibilities with MineClone 5 and older versions of MineClone 2, but tried to use the mod in Mineclonia.

As everything seemed to work fine, I used the mod and played many hours in the world, but strange problems with signs keep appearing. They report a missing texture, while the text is still there (though barely readable due to the missing texture image). This happens to various types of wood (haven't tested all) and to standing and wall signs.

As I thought this to be a Mineclonia problem, I reported it to the issue tracker there (codeberg.org, there under the name Kyoushi), but the community could not reproduce the problem, but told me to check the mods.

Therefore I started a new world, set up everything similar to like before (and placed various signs here and there for testing purposes) and activated and deactivated one mod after the other and played a few hours each time to see if the problem occurs. After enabling "Fish Traps for MineClone2" and placing one fish trap, suddenly the texture error occurred again.

In the pictures you cannot see it, but sometimes on my trading hall only some of the signs are affected, but every time signs near to each other. Never a broken texture sign between flawless one, never one flawless one between two broken ones.

From time to time the error seem to fix itself for a short time, but when I come back some time later, the error is there again. I cannot reproduce when exactly the error occurs or what fixes it, as it most of the time is persistent even when I leave the area more than hundred blocks away or if I restart Minetest and/or reload the world.

I know you warned about possible incompatibilities, but if this is maybe only a small problem, maybe you could fix it if you find the time?

This is a great plugin I would really miss in Mineclonia!

Thank you! :-)

Zwischenablage3

Laudrin commented 10 months ago

One further addition: After deactivating the fish trap mod in my new world, and removing the unknown block which was formerly the fishing trap (I forgot it before disabling the mod) and quitting the world again, I got the following error:

ModError beim Herunterfahren: Runtime error from mod '??' in callback luaentity_GetStaticdata(): ...\games\mineclonia\mods\ENTITIES\mcl_entity_invs\init.lua:161: mcl_entity_invs currently only works with entities that return a (serialized) table in get_staticdata. mobs_mc:llama returned: nil
stack traceback:
    [C]: in function 'assert'
    ...\games\mineclonia\mods\ENTITIES\mcl_entity_invs\init.lua:161: in function <...\games\mineclonia\mods\ENTITIES\mcl_entity_invs\init.lua:158>
Für mehr Details siehe debug.txt.

Not sure if this was also caused by the mod. As this was removing a mod from an existing world and forgetting to remove the fishing trap before, this may be caused by this. But maybe another thing to look into it.

I reported the error in the Mineclonia issue tracker, too, and will inform you if they find the error to be in Minetest or Mineclonia and not in the mod.

As a further addition to the texture problem: I had to remove the signs which had the texture error (there were ca. 6 signs on the left side of my trading hall with the error, all signs on the right side were okay). As this was not helping in my other world while the mod was enabled, it fixed the problem here with the disabled mod. I now played some hours after removing without the error showing up again. In my other world the error was there again after a short while.

Laudrin commented 10 months ago

Sorry for the third comment in a short row, but I translated the mod's text to German to include into the mod. I don't know how to do it the right way, so I just included it here. Hope that's okay and someone can include it into the mod.

As Github does not allow files with .tr suffix, I put a .txt after the name. Please just remove it before putting it into the locale folder.

Please be aware that there is a special word for a fishing trap "Fischreuse", while "trap" is usually translated with "Falle". I used "Fischfalle" because this is commonly understood while "Reuse" is an infrequently used word.

mcl_fish_traps.de.tr.txt

wsor4035 commented 10 months ago

Sorry for the third comment in a short row, but I translated the mod's text to German to include into the mod. I don't know how to do it the right way, so I just included it here. Hope that's okay and someone can include it into the mod.

As Github does not allow files with .tr suffix, I put a .txt after the name. Please just remove it before putting it into the locale folder.

Please be aware that there is a special word for a fishing trap "Fischreuse", while "trap" is usually translated with "Falle". I used "Fischfalle" because this is commonly understood while "Reuse" is an infrequently used word.

mcl_fish_traps.de.tr.txt

see https://github.com/mt-mods/mcl_fish_traps/pull/2, made it as a pr, if you could test the branch out and verify it works? - also to keep the issue related to the texture issue, please comment regarding translation over there

wsor4035 commented 10 months ago

image

fresh mcla world, placed some signs, added some text, works fine, cant replicate the issue

Laudrin commented 10 months ago

fresh mcla world, placed some signs, added some text, works fine, cant replicate the issue

Thank you for testing! :-)

The problem did not occur everywhere. Some signs are fine. Other show this problem. I try again with a new world and report later if I have the same problem.

Maybe it only shows up in villages?