mt-mods / mcl_fish_traps

GNU General Public License v3.0
0 stars 1 forks source link

Changes and Feature Consideration #4

Open KAnon20 opened 3 months ago

KAnon20 commented 3 months ago

Issue 1 (resolved): The water source texture from the Minetest.net build (and Minetest launcher) don't work but this repository seems to.

Issue 2: VoxeLibre has changed fishing output. In Junk;

  1. Black Dye has been swapped with mcl_mobitems:ink_sac
  2. Added { itemstring = "mcl_bamboo:bamboo", weight = 10 },

In Treasure;

  1. Added { itemstring = "mcl_mobitems:spectre_membrane", },
  2. Added { itemstring = "mcl_mobitems:crystalline_drop", },

Issue 3: I beleive I don't get Junk and I get Treasure often. At first, I thought it was because it checked players inventory and chests for fishing rods with Luck of the Sea but this repeats in new games. Also, I tried it with Logistica automation and I got no String, Leather, Rotten Flesh, Leather boots, Bone, Bottle of Water, etc. even after fishing up over 80k Raw Fish (, 13k Puffer Fish, and 1200 Clownfish), I seemed to have gotten no Junk.

Ocraw commented 3 months ago

You can use my fork in the meantime, it's nothing official but it fixes a couple stuff. No idea what mt-mods have planned for this mod, but I guess it will be better and cleaner than what I'm doing at the moment, so don't take it as a permanent replacement.

Hope I'm not doing something wrong pointing to a different fork, just trying to help.

Also, mt-mods, feel free to just take stuff from there if you feel, not sure if it's worth to create a pull request from me. (Not even sure if I got how pull requests work yet)

wsor4035 commented 3 months ago

You can use my fork in the meantime, it's nothing official but it fixes a couple stuff. No idea what mt-mods have planned for this mod, but I guess it will be better and cleaner than what I'm doing at the moment, so don't take it as a permanent replacement.

Hope I'm not doing something wrong pointing to a different fork, just trying to help.

Also, mt-mods, feel free to just take stuff from there if you feel, not sure if it's worth to create a pull request from me. (Not even sure if I got how pull requests work yet)

please consider contributing back upstream(probably in a couple prs looking at the changes)

wsor4035 commented 3 months ago

if you dont mind/are uncomfortable with doing a pull request i can pick commits from your code and put together prs from them if you would like?

Ocraw commented 3 months ago

I tried, not sure if that's what you meant, let me know if I need to do something else.