small poplar trees seed not to exist anymore

[fluxionary]

all poplar saplings grow into the same size (ongen included). i'm pretty sure it wasn't always this way.

also, the icon for the small poplar ongen sapling is incorrect.

[Niklp09]

confirmed

[S-S-X]

Yeah, it seemed to be planned change but I didn't like it. 100% support for restoring small poplars and also keeping old challenges for making those small poplars actually grow. At least it was different in many ways which actually did make it very special.

[wsor4035]

assuming s/seed/sapling from the title, it looks like when placed the small varient is getting converted to a large one by an abm/lbm perhaps. as for the icon, it is only incorrect for the fast growth/on gen one

[wsor4035]

some weirdness happening here https://github.com/mt-mods/moretrees/blob/master/node_defs.lua#L567-L590 if i comment out the register_node's, it breaks the non fast growth, and removes the texture from the fast growth, but it the small fast growth does grow properly. have to try and figure out what is up with this workaround code

edit: the poplar small regular sapling isnt registered because there is an if statement which looks like its supposed to prevent the wood/stairs/etc from getting registered for defaults nodes. aka it looks like poplar got stuck in here rather than getting its own exception

[wsor4035]

ok, will be pushing a fix to master shortly for this. issue caused by existing hacky workarounds

[wsor4035]

tldr the issue was caused by a hacky workaround of including the small variant in the same exception for the default trees, so i removed it from there, and properly supported in the regular registration while removing the old hacky workarounds