search

mt-mods / moretrees

Other
8 stars 10 forks source link

tune for voxel garden #40

Closed wsor4035 closed 1 month ago

wsor4035 commented 1 month ago

alternative to https://github.com/mt-mods/moretrees/pull/38

@j-r thoughts?

j-r commented 1 month ago

Thanks for working on this. Looks good to me, will take it for a test drive (but I don't expect problems).

My unqualified (not having your experience in this domain) personal opinion is that in the long run it probably would be better to base the decision on some kind of feature API instead of game id, but at this point it probably isn't possible to come up with an adequate list of features.

Anyway, I'd like to suggest to add the (internal) settings entry after all and have the gameid check only there in one place with a suitable comment, better documenting why that particular feature is disabled (since probably not everybody knows all VG gameplay feature details).

wsor4035 commented 1 month ago

thoughts on the latest commit?

j-r commented 1 month ago

thoughts on the latest commit?

Makes me happy:-)

EDIT: and is working, too! (note that leaf decay doesn't work quite right yet, but that is a separate issue)