mt-mods / moretrees

Other
8 stars 10 forks source link

Date drop table seems broken #7

Open axcore opened 2 years ago

axcore commented 2 years ago

Hanging dates, when dropped, produce individual dates. In date_palm.lua:

https://github.com/mt-mods/moretrees/blob/cbe846dfde7894cb0f7996dadc57001da3501936/date_palm.lua#L680-L699

Presumably this means that hanging dates (e.g. moretrees:dates_f4) should drop between 4 and 20 individual dates (i.e. moretrees:date).

For reasons I can't explain, this is not what happens. If you have 0 individual dates in your inventory, you get 1 date. If you have 1 or more dates in your inventory, you get no dates at all.

I experimented with changing the code to this, which behaves exactly as expected:

local dates_drop = {
    items = {
        {items = {"unilib:fruit_date 4"}},
        {items = {"unilib:fruit_date 8"}, rarity = 2},
        {items = {"unilib:fruit_date 12"}, rarity = 5},
        {items = {"unilib:fruit_date 16"}, rarity = 20},
    }
}

Sorry for the formatting. I don't know why Github can't handle a newline character.

OgelGames commented 2 years ago

It works correctly in my testing, so I'm guessing it's either an alias issue (looking at unilib:fruit_date in your fix), or you're testing it in creative, which would cause that behavior.

Sorry for the formatting. I don't know why Github can't handle a newline character.

It needs three backticks for multiline code, I fixed it up for you :)