mt-mods / pipeworks

Pipeworks is a mod for Minetest allowing the crafting and usage of pipes and tubes
Other
14 stars 17 forks source link

de-duplicate chest code #123

Closed a-tour-ist closed 3 months ago

a-tour-ist commented 3 months ago

@fluxionary already mentioned in #122 that the chest override code is behind mtg. While the specific bug mentioned there got fixed already, other long-fixed bugs from mtg, such as https://github.com/minetest/minetest_game/pull/1884 still appear with the pipeworks version.

The approach of this PR consists of 2 parts: 1) The override table for the chests is nearly always the same, mostly only changes in the tiles. So I made a general function to override any given chest to be compatible with pipeworks 2) The splitstacks switch in the formspec:

I tested everything I can imagine, I hope I missed nothing :-)

SwissalpS commented 3 months ago

ran this on a pandorabox-mods world. I didn't test the duplication part, mainly focused on optics and tube functions on technic chests and machines. No obvious errors found this way.

BuckarooBanzay commented 3 months ago

thanks :+1: